Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-slider): correct description of slider … #23431

Merged
merged 2 commits into from Aug 24, 2021
Merged

fix(material-experimental/mdc-slider): correct description of slider … #23431

merged 2 commits into from Aug 24, 2021

Conversation

wagnermaciel
Copy link
Contributor

…harness thumb getters

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 23, 2021
@wagnermaciel wagnermaciel added target: patch This PR is targeted for the next patch release and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Aug 23, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 23, 2021
@wagnermaciel wagnermaciel added merge safe and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Aug 23, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 23, 2021
@wagnermaciel wagnermaciel added area: material/slider and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Aug 23, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 23, 2021
crisbeto
crisbeto approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe we should throw an error if the method is called on a non-range slider?

@wagnermaciel
fix(material-experimental/mdc-slider): throw helpful error when wrong…
0df80b0 
… slider thumb getter is used

* added a unit test to make sure this error works properly
@wagnermaciel
Copy link
Contributor Author

@crisbeto I added a helpful error message and a unit test to verify that the error gets thrown correctly

crisbeto
crisbeto approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Aug 24, 2021
@amysorto amysorto merged commit c4cf3c9 into angular:master Aug 24, 2021
amysorto pushed a commit that referenced this pull request Aug 24, 2021
@wagnermaciel @amysorto
fix(material-experimental/mdc-slider): correct description of slider … (
e725863 
#23431)

* fix(material-experimental/mdc-slider): correct description of slider harness thumb getters

* fix(material-experimental/mdc-slider): throw helpful error when wrong slider thumb getter is used

* added a unit test to make sure this error works properly

(cherry picked from commit c4cf3c9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: material/slider cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wagnermaciel @crisbeto @amysorto