Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material-experimental/mdc-slider): append class to indicate short… #23566

Merged
merged 1 commit into from Sep 16, 2021
Merged

fix(material-experimental/mdc-slider): append class to indicate short… #23566

merged 1 commit into from Sep 16, 2021

Conversation

wagnermaciel
Copy link
Contributor

… value indicator text

  • This class is only used internally. It is a temporary fix which will be removed
    once the appending of this class is handled by the mdc foundation (cl/388828896).

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 10, 2021
@wagnermaciel wagnermaciel added target: patch This PR is targeted for the next patch release merge safe labels Sep 10, 2021
@wagnermaciel
Copy link
Contributor Author

@jelbourn cl/388828896 is going to take a while to get in. This is a temporary fix while that CL is pending. I've already submitted cl/395925245 in preparation for this fix

@wagnermaciel wagnermaciel marked this pull request as ready for review September 10, 2021 15:02
jelbourn
jelbourn approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can add merge ready when ready

src/material-experimental/mdc-slider/slider.ts Outdated Show resolved Hide resolved
@google-cla
Copy link

google-cla bot commented Sep 10, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Sep 10, 2021
@wagnermaciel wagnermaciel added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Sep 10, 2021
@wagnermaciel
fix(material-experimental/mdc-slider): append class to indicate short…
23e6874 
… value indicator text

* This class is only used internally. It is a temporary fix which will be removed
  once the appending of this class is handled by the mdc foundation (cl/388828896).
@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Sep 10, 2021
crisbeto
crisbeto reviewed Sep 11, 2021
View reviewed changes
src/material-experimental/mdc-slider/slider.ts
@@ -150,6 +154,11 @@ export class MatSliderVisualThumb implements AfterViewInit, OnDestroy {
this._elementRef.nativeElement.removeEventListener('mouseleave', this._onMouseLeave);
}

/** Used to append a class to indicate when the value indicator text is short. */
_isShortValue(): boolean {
return this.valueIndicatorText?.length <= 2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it might be a good idea to initialize the valueIndicatorText to an empty string so that we don't have to null check it everywhere. That would also make it easier to inline the entire expression in the host binding.

@wagnermaciel wagnermaciel merged commit 4160f11 into angular:master Sep 16, 2021
wagnermaciel added a commit that referenced this pull request Sep 16, 2021
@wagnermaciel
fix(material-experimental/mdc-slider): append class to indicate short…
82fd042 
… value indicator text (#23566)

* This class is only used internally. It is a temporary fix which will be removed
  once the appending of this class is handled by the mdc foundation (cl/388828896).

(cherry picked from commit 4160f11)
@sync-by-unito sync-by-unito bot mentioned this pull request Oct 1, 2021
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto left review comments

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wagnermaciel @jelbourn @crisbeto