Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cdk/a11y): use correct method when updating active item #24232

Merged
merged 1 commit into from Jan 19, 2022

Conversation

crisbeto
Copy link
Member

Follow-up to #14471. Uses setActiveItem instead of updateActiveItem which was missed when addressing the feedback.

Follow-up to angular#14471. Uses `setActiveItem` instead of `updateActiveItem` which was missed when addressing the feedback.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jan 19, 2022
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker merge safe labels Jan 19, 2022
@andrewseguin andrewseguin merged commit 0b436c4 into angular:master Jan 19, 2022
andrewseguin pushed a commit that referenced this pull request Jan 19, 2022
)

Follow-up to #14471. Uses `setActiveItem` instead of `updateActiveItem` which was missed when addressing the feedback.

(cherry picked from commit 0b436c4)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants