fix(material/badge): ensure overflow visible #24602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewseguin
added
the
target: patch
crisbeto
approved these changes
Mar 16, 2022
| // style `overflow: hidden` so this requires extra specificity so that it does not | ||
| // depend on style load order. | ||
| .mat-badge.mat-badge { | ||
| overflow: visible; |
There was a problem hiding this comment.
Optional: should we just make this !important?
There was a problem hiding this comment.
If so let's do it in another PR just because we want to get this in before the release goes out so the "next" version doesn't have broken icon badges, and I've got a TGP for this version of the fix. Technically this seems to be a good candidate for actually using important than its critical to the component working
andrewseguin
added a commit
that referenced
this pull request
Mar 16, 2022
(cherry picked from commit 0f15d19)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Mar 23, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.2.6/13.3.0) | | [@angular/material](https://github.com/angular/components) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.2.6/13.3.0) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.3.0`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1330-aluminum-armadillo-2022-03-16) [Compare Source](angular/components@13.2.6...13.3.0) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [e4c64dd56](angular/components@e4c64dd) | fix | **drag-drop:** only block dragstart event on event targets ([#​24581](angular/components#24581)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [33d07df95](angular/components@33d07df) | fix | **badge:** ensure overflow visible ([#​24602](angular/components#24602)) | | [dfef17351](angular/components@dfef173) | fix | **datepicker:** fix Voiceover losing focus on PageDown ([#​24399](angular/components#24399)) | | [1703b83ae](angular/components@1703b83) | fix | **datepicker:** use cdk-visually-hidden on calendar header ([#​24523](angular/components#24523)) | | [41320d07e](angular/components@41320d0) | fix | **tabs:** avoid timeouts in background tabs ([#​24000](angular/components#24000)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [097ec0d11](angular/components@097ec0d) | fix | **mdc-core:** add app background color ([#​22992](angular/components#22992)) | | [15a0676d5](angular/components@15a0676) | fix | **mdc-radio:** add hover indication ([#​24595](angular/components#24595)) | #### Special Thanks Andrew Seguin, Kristiyan Kostadinov, Paul Gschwendtner and Zach Arend <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1229 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regression was introduced when the icon changed styles to be overflow hidden. This makes sure the host element always allows the badge to fully render outside of the host's bounding box