fix(select): remove selection if option is removed #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
requested changes
Jan 12, 2017
| firstOption.click(); | ||
| fixture.detectChanges(); | ||
|
|
||
| expect(select.selected).toBe(select.options.first); |
There was a problem hiding this comment.
Can you add fallback messages for both assertions if the test fails? e.g. Expected first option to be selected.
kara
added
pr: lgtm
blocked
devversion
force-pushed
the
fix/selection-options-change
branch
from
019e2fc
to
3f765ae
Compare
* Currenty when an option is selected and the option is somehow programmatically removed the select updates its options. Right now it does not remove the selection if the selection has been removed from the options. Fixes angular#2524
devversion
force-pushed
the
fix/selection-options-change
branch
from
3f765ae
to
86e7963
Compare
kara
removed
the
blocked
kara
pushed a commit
to kara/material2
that referenced
this pull request
Jan 20, 2017
* fix(select): remove selection if option is removed * Currenty when an option is selected and the option is somehow programmatically removed the select updates its options. Right now it does not remove the selection if the selection has been removed from the options. Fixes angular#2524 * Update spec name * Remove check logic and just keep test * Update expectation message * Fix linting * Wait for zone to be stable
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currenty when an option is selected and the option is somehow programmatically removed the select updates its options.
Right now it does not remove the selection if the selection has been removed from the options.
Fixes #2524