fix(cdk/dialog): use inert to block content outside of dialog #25666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
devversion and
jelbourn
as code owners
crisbeto
added
dev-app preview
crisbeto
force-pushed
the
dialog-inert
branch
from
2d2eb16
to
a2128d4
Compare
|
Deployed dev-app to: https://ng-comp-dev--pr-25666-758588da5f5a0dae4da09ba558bf3e60-kk0pfpgo.web.app |
crisbeto
force-pushed
the
dialog-inert
branch
from
a2128d4
to
758588d
Compare
crisbeto
removed
the
dev-app preview
|
I spent some time presubmitting this and I think it'll be tricky to land, because the automated a11y checking tools don't account for |
Currently we're setting `aria-hidden` on all elements outside of a dialog in order to prevent assistive technology from interacting with it. These changes switch to using the `inert` attribute when supported which resolves some long-standing issues like tabbing directly into the dialog from the address bar.
crisbeto
force-pushed
the
dialog-inert
branch
from
758588d
to
1fcfe74
Compare
|
any luck the tool is now accounting now for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we're setting
aria-hiddenon all elements outside of a dialog in order to prevent assistive technology from interacting with it. These changes switch to using theinertattribute when supported which resolves some long-standing issues like tabbing directly into the dialog from the address bar.