New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(material/chips): allow custom default color #25687
base: main
Are you sure you want to change the base?
Conversation
3e55202
to
f92379a
Compare
a673ce5
to
1648257
Compare
ae05a5c
to
152dde3
Compare
Thank you! 😄 |
Thank you for the contribution :) I'll run this by internal Google tests to make sure it can be merged |
One more thing - youll need to run |
There were some failures internally, I'll try to take a look this week to determine what's going on |
Hey thanks for your patience with this PR - this was on the backburner as we prepare v15's MDC launch. I looked at the failures. We need just one small change to |
Lets the user choose what color will be the default instead of 'primary' via mixinColor
Lets the user choose what color will be the default instead of 'primary' via mixinColor
3457ea1
to
c013998
Compare
Good news is that now all tests pass internally and externally, but unfortunately this missed our window for getting in for v15. We're in a feature freeze until November's release, but once that passes we can get this merged in. Thanks for your contribution and patience :) |
Hi Andrew, |
Lets the user choose what color will be the default instead of 'primary' via mixinColor
✅ Tests adapted
✅ No breaking change: I keep the same default color
primary