Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(material/chips): allow custom default color #25687

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Nxtivision
Copy link

Lets the user choose what color will be the default instead of 'primary' via mixinColor

✅ Tests adapted
✅ No breaking change: I keep the same default color primary

@Nxtivision Nxtivision changed the title Feat(chip): allow custom default color feat(material/chips): allow custom default color Sep 23, 2022
@Nxtivision
Copy link
Author

Thank you! 😄

@andrewseguin
Copy link
Contributor

Thank you for the contribution :) I'll run this by internal Google tests to make sure it can be merged

@andrewseguin andrewseguin added the target: major This PR is targeted for the next major release label Sep 26, 2022
@andrewseguin
Copy link
Contributor

One more thing - youll need to run yarn bazel run //tools/public_api_guard:material/chips.md_api.accept to edit the API goldens

@angular-robot angular-robot bot added the area: docs Related to the documentation label Sep 26, 2022
@andrewseguin
Copy link
Contributor

There were some failures internally, I'll try to take a look this week to determine what's going on

@andrewseguin
Copy link
Contributor

Hey thanks for your patience with this PR - this was on the backburner as we prepare v15's MDC launch. I looked at the failures. We need just one small change to chip-row.ts which calls the super MatChip constructor. You'll want to inject and pass the default options in the constructor.

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Oct 14, 2022
@andrewseguin
Copy link
Contributor

Good news is that now all tests pass internally and externally, but unfortunately this missed our window for getting in for v15. We're in a feature freeze until November's release, but once that passes we can get this merged in. Thanks for your contribution and patience :)

@Nxtivision
Copy link
Author

Hi Andrew,
Thank you for letting me know about this ! :) Can we expect it to be released before the end of this year ?

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed target: major This PR is targeted for the next major release labels Nov 28, 2022
@andrewseguin andrewseguin removed their assignment Jun 5, 2023
@mmalerba mmalerba removed their request for review June 9, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants