fix(material/datepicker): unable to click datepicker toggle when form field is disabled #25863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… field is disabled We support the case where the form field is disabled, but the datepicker isn't. Currently this is broken, because MDC sets `pointer-events: none` on the entire form field when it is disabled. These changes add `pointer-events: auto` only on the toggle to enable clicking.
crisbeto
added
P3
zarend
approved these changes
Oct 25, 2022
| @@ -1,5 +1,11 @@ | |||
| @use '@angular/cdk'; | |||
|
|
|||
| // We support the case where the form field is disabled, but the datepicker is not. | |||
There was a problem hiding this comment.
typo: "datepicker does not"
There was a problem hiding this comment.
I think that "is not" is correct since the first part of the sentence says "the form field is disabled".
crisbeto
added
action: merge
crisbeto
added a commit
that referenced
this pull request
Oct 26, 2022
… field is disabled (#25863) We support the case where the form field is disabled, but the datepicker isn't. Currently this is broken, because MDC sets `pointer-events: none` on the entire form field when it is disabled. These changes add `pointer-events: auto` only on the toggle to enable clicking. (cherry picked from commit fe44107)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We support the case where the form field is disabled, but the datepicker isn't. Currently this is broken, because MDC sets
pointer-events: noneon the entire form field when it is disabled. These changes addpointer-events: autoonly on the toggle to enable clicking.