fix(material/select): active class not removed from reset option when new value is assigned through form control #26414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new value is assigned through form control Fixes that we weren't removing the active class from a reset option when a new value is assigned through a `FormControl`. The problem was that we were removing the active classes only from selected options, but a reset option is never selected. Fixes angular#26390.
crisbeto
added
P3
devversion
approved these changes
Jan 12, 2023
crisbeto
added a commit
that referenced
this pull request
Jan 12, 2023
… new value is assigned through form control (#26414) Fixes that we weren't removing the active class from a reset option when a new value is assigned through a `FormControl`. The problem was that we were removing the active classes only from selected options, but a reset option is never selected. Fixes #26390. (cherry picked from commit 769e204)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jan 20, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.1.0/15.1.1) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`15.1.0` -> `15.1.1`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.1.0/15.1.1) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v15.1.1`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1511-purple-plush-2023-01-18) [Compare Source](angular/components@15.1.0...15.1.1) ##### material | Commit | Type | Description | | -- | -- | -- | | [0fc52fca6](angular/components@0fc52fc) | fix | **schematics:** don't migrate unknown stylesheet formats ([#​26450](angular/components#26450)) | | [6bdc2e383](angular/components@6bdc2e3) | fix | **select:** active class not removed from reset option when new value is assigned through form control ([#​26414](angular/components#26414)) | | [072d6d036](angular/components@072d6d0) | fix | **slider:** Use non-deprecated theme key ([#​26378](angular/components#26378)) | #### Special Thanks Alan Agius, Alka Vats, Kevin Vizcarra, Kristiyan Kostadinov and Paul Gschwendtner <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDUuMyIsInVwZGF0ZWRJblZlciI6IjM0LjEwNi4wIn0=--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1741 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
@crisbeto is it possible to include also on v14? This was actually reported on version 14. |
|
We don't backport bug fixes to older versions, unless they're related to security. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that we weren't removing the active class from a reset option when a new value is assigned through a
FormControl. The problem was that we were removing the active classes only from selected options, but a reset option is never selected.Fixes #26390.