Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/tabs): unable to click projected content in tab label #26527

Merged
merged 1 commit into from Feb 1, 2023

Conversation

crisbeto
Copy link
Member

Fixes that the MDC-based tabs implementation didn't allow clicks on the projected content inside a tab, because MDC was setting pointer-events: none.

Fixes #26195.

Fixes that the MDC-based tabs implementation didn't allow clicks on the projected content inside a tab, because MDC was setting `pointer-events: none`.

Fixes angular#26195.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jan 31, 2023
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Feb 1, 2023
@crisbeto crisbeto self-assigned this Feb 1, 2023
@crisbeto crisbeto merged commit fd9853d into angular:main Feb 1, 2023
crisbeto added a commit that referenced this pull request Feb 1, 2023
…26527)

Fixes that the MDC-based tabs implementation didn't allow clicks on the projected content inside a tab, because MDC was setting `pointer-events: none`.

Fixes #26195.

(cherry picked from commit fd9853d)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Feb 3, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.1.2/15.1.3) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`15.1.2` -> `15.1.3`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.1.2/15.1.3) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v15.1.3`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1513-obsidian-organism-2023-02-02)

[Compare Source](angular/components@15.1.2...15.1.3)

##### cdk

| Commit | Type | Description |
| -- | -- | -- |
| [d9124166a1](angular/components@d912416) | fix | **collections:** SelectionModel does not always respect the compareWith function ([#&#8203;26447](angular/components#26447)) |

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [621d1755df](angular/components@621d175) | fix | **checkbox:** focus not moved to input when clicking on touch target ([#&#8203;26545](angular/components#26545)) |
| [f1d83f19c9](angular/components@f1d83f1) | fix | **dialog:** take dialog background from theme palette ([#&#8203;26324](angular/components#26324)) |
| [719cff0c4d](angular/components@719cff0) | fix | **tabs:** set color on disabled tabs ([#&#8203;26319](angular/components#26319)) |
| [9efb60f6b4](angular/components@9efb60f) | fix | **tabs:** unable to click projected content in tab label ([#&#8203;26527](angular/components#26527)) |

##### google-maps

| Commit | Type | Description |
| -- | -- | -- |
| [e48a5af71f](angular/components@e48a5af) | fix | error if API is initialized incorrectly ([#&#8203;26520](angular/components#26520)) |

#### Special Thanks

Alan Agius, Aurélien Loyer, Kristiyan Kostadinov, MECHERI Akram, Paul Gschwendtner, Pei Wang and Wagner Maciel

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTkuMiIsInVwZGF0ZWRJblZlciI6IjM0LjEyMC4wIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1768
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Mat tab): Not able to click on icon inside mat tab
2 participants