Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/core): don't use font shorthand property in typography-level #26865

Conversation

jonathan-meier
Copy link
Contributor

This avoids overriding font properties with default values that can't be configured in the current typography config, e.g. the font-variant-caps or font-feature-settings property.

Fixes #26864

…evel

This avoids overriding font properties with default values that can't be configured in the current typography config, e.g. the font-variant-caps or font-feature-settings property.

Fixes angular#26864
@jelbourn jelbourn added G This is is related to a Google internal issue area: theming labels Mar 30, 2023
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker and removed target: minor This PR is targeted for the next minor release labels Apr 4, 2023
@angular-robot angular-robot bot merged commit 1375505 into angular:main Apr 4, 2023
26 of 28 checks passed
angular-robot bot pushed a commit that referenced this pull request Apr 4, 2023
…evel (#26865)

This avoids overriding font properties with default values that can't be configured in the current typography config, e.g. the font-variant-caps or font-feature-settings property.

Fixes #26864

Co-authored-by: Jonathan Meier <jome@google.com>
(cherry picked from commit 1375505)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Apr 9, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`15.2.5` -> `15.2.6`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.2.5/15.2.6) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`15.2.5` -> `15.2.6`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.2.5/15.2.6) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v15.2.6`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1526-chiffon-cardigan-2023-04-05)

[Compare Source](angular/components@15.2.5...15.2.6)

##### cdk

| Commit | Type | Description |
| -- | -- | -- |
| [cc5f7d0890](angular/components@cc5f7d0) | fix | **menu:** move focus when opening via click ([#&#8203;26874](angular/components#26874)) |

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [fd58310a1f](angular/components@fd58310) | fix | **core:** don't use font shorthand property in typography-level ([#&#8203;26865](angular/components#26865)) |

#### Special Thanks

Jonathan Meier and Kristiyan Kostadinov

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4zMi4yIiwidXBkYXRlZEluVmVyIjoiMzUuMzIuMiJ9-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1850
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@andrewseguin andrewseguin self-assigned this Jun 2, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: theming G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release
Projects
None yet
3 participants