Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-luxon-adapter): zone on DateTime ignored #26887

Merged
merged 1 commit into from Apr 6, 2023
Merged

fix(material-luxon-adapter): zone on DateTime ignored #26887

merged 1 commit into from Apr 6, 2023

Conversation

cusher
Copy link
Contributor

@cusher cusher commented Apr 5, 2023

Fixes a bug where the timezone on the Luxon DateTime is thrown away during conversion to string, resulting in using the Luxon defaultZone regardless of how the particular DateTime is configured.

Fixes #26869

Fixes a bug where the timezone on the Luxon DateTime is thrown away during conversion to string,
resulting in using the Luxon defaultZone regardless of how the particular DateTime is configured.

Fixes #26869
@cusher cusher requested a review from crisbeto as a code owner April 5, 2023 22:06
@google-cla
Copy link

google-cla bot commented Apr 5, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 6, 2023
@angular-robot angular-robot bot merged commit 00ff979 into angular:main Apr 6, 2023
23 checks passed
angular-robot bot pushed a commit that referenced this pull request Apr 6, 2023
Fixes a bug where the timezone on the Luxon DateTime is thrown away during conversion to string,
resulting in using the Luxon defaultZone regardless of how the particular DateTime is configured.

Fixes #26869

(cherry picked from commit 00ff979)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Apr 28, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`15.2.6` -> `15.2.8`](https://renovatebot.com/diffs/npm/@angular%2fcdk/15.2.6/15.2.8) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`15.2.6` -> `15.2.8`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/15.2.6/15.2.8) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v15.2.8`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1528-nickel-nickel-2023-04-19)

[Compare Source](angular/components@15.2.7...15.2.8)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [af293a124](angular/components@af293a1) | fix | **core:** remove tabindex from mat-option ([#&#8203;26917](angular/components#26917)) |
| [5623a8c8b](angular/components@5623a8c) | fix | **form-field:** inconsistent height for non-text inputs ([#&#8203;26941](angular/components#26941)) |

<!-- CHANGELOG SPLIT MARKER -->

### [`v15.2.7`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1527-paper-pelican-2023-04-13)

[Compare Source](angular/components@15.2.6...15.2.7)

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [de22cdc72](angular/components@de22cdc) | fix | **table:** correct filterPredicate typo ([#&#8203;26902](angular/components#26902)) |

##### material-luxon-adapter

| Commit | Type | Description |
| -- | -- | -- |
| [6c00403a8](angular/components@6c00403) | fix | zone on DateTime ignored ([#&#8203;26887](angular/components#26887)) |

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [x] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzUuNjEuMCJ9-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1865
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(LuxonDateAdapter): Zone set on DateTime ignored
2 participants