Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/datepicker): date range input incorrectly inheriting text color #26988

Merged
merged 1 commit into from Apr 27, 2023
Merged

fix(material/datepicker): date range input incorrectly inheriting text color #26988

merged 1 commit into from Apr 27, 2023

Conversation

crisbeto
Copy link
Member

Fixes that the MDC-based date range input was inheriting the text color instead of setting its own, because it was missing one of the MDC CSS classes.

Fixes #26925.

@crisbeto
fix(material/datepicker): date range input incorrectly inheriting tex…
4fb6a98 
…t color

Fixes that the MDC-based date range input was inheriting the text color instead of setting its own, because it was missing one of the MDC CSS classes.

Fixes angular#26925.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 25, 2023
wagnermaciel
wagnermaciel approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 27, 2023
@angular-robot angular-robot bot merged commit 1fcbcac into angular:main Apr 27, 2023
27 checks passed
angular-robot bot pushed a commit that referenced this pull request Apr 27, 2023
@crisbeto
fix(material/datepicker): date range input incorrectly inheriting tex…
757a456 
…t color (#26988)

Fixes that the MDC-based date range input was inheriting the text color instead of setting its own, because it was missing one of the MDC CSS classes.

Fixes #26925.

(cherry picked from commit 1fcbcac)
angular-robot bot pushed a commit that referenced this pull request Apr 27, 2023
@crisbeto
fix(material/datepicker): date range input incorrectly inheriting tex…
701f2b7 
…t color (#26988)

Fixes that the MDC-based date range input was inheriting the text color instead of setting its own, because it was missing one of the MDC CSS classes.

Fixes #26925.

(cherry picked from commit 1fcbcac)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba mmalerba is a code owner

@zarend zarend Awaiting requested review from zarend

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(material/date-picker): gray text color of input value in mat-dialog
2 participants
@crisbeto @wagnermaciel