fix(material/tabs): avoid unnecessary updates of tab ink bar #27031
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a resize observer in the
paginated-tab-header
, that calls_alignInkBarToSelectedTab
method herecomponents/src/material/tabs/paginated-tab-header.ts
Line 206 in 946cc67
This causes the ink bar to be updated each time there's any size change. Sometimes it can cause additional problems. For example, in our case we are slightly customizing the UI so that selected tab has larger font weight than others. And this actually triggers the resize observer, which attempts to redraw the ink bar twice and breaks the ink bar animation
Untitled.1.mp4