Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/tooltip): Move unthemable tokens to theme mixin #27569

Merged

Conversation

amysorto
Copy link
Contributor

@amysorto amysorto commented Aug 2, 2023

Though these tokens are not currently affected by the theme, in the future they will be affected by the design system used for theming (M2 or M3)

BREAKING CHANGE:
There are new styles emitted by mat.tooltip-theme that are not
emitted by any of: mat.tooltip-color, mat.tooltip-typography,
mat.tooltip-density. If you rely on the partial mixins only and don't
call mat.tooltip-theme, you can add mat.tooltip-base to get the
missing styles.

@amysorto amysorto force-pushed the unthemable-tooltip-tokens-to-theme-mixin branch from 254c206 to 640d4e5 Compare August 2, 2023 23:38
Though these tokens are not currently affected by the theme, in the future they will be affected by the design system used for theming (M2 or M3)

BREAKING CHANGE:
There are new styles emitted by mat.tooltip-theme that are not
emitted by any of: mat.tooltip-color, mat.tooltip-typography,
mat.tooltip-density. If you rely on the partial mixins only and don't
call mat.tooltip-theme, you can add mat.tooltip-base to get the
missing styles.
@amysorto amysorto force-pushed the unthemable-tooltip-tokens-to-theme-mixin branch from 640d4e5 to bc79058 Compare August 3, 2023 22:56
@angular-robot angular-robot bot added the detected: breaking change PR contains a commit with a breaking change label Aug 3, 2023
@amysorto amysorto added the target: major This PR is targeted for the next major release label Aug 3, 2023
@amysorto amysorto requested a review from mmalerba August 3, 2023 23:01
@amysorto amysorto marked this pull request as ready for review August 3, 2023 23:01
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amysorto amysorto added the action: merge The PR is ready for merge by the caretaker label Aug 4, 2023
@amysorto amysorto merged commit ccd2d7f into angular:main Aug 4, 2023
26 of 29 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants