Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/slider): Emit tokens under mixin root selector #27597

Merged
merged 1 commit into from Oct 11, 2023
Merged

fix(material/slider): Emit tokens under mixin root selector #27597

merged 1 commit into from Oct 11, 2023

Conversation

amysorto
Copy link
Contributor

@amysorto amysorto commented Aug 7, 2023

No description provided.

@amysorto amysorto force-pushed the emit-slider-tokens-under-mixin-root-selector branch from d8880a4 to 8857503 Compare August 7, 2023 23:23
@amysorto amysorto changed the title fix(material/slider): Move unthemable tokens to theme mixin fix(material/slider): Emit tokens under mixin root selector Aug 7, 2023
@amysorto amysorto force-pushed the emit-slider-tokens-under-mixin-root-selector branch from 8857503 to 0b115b3 Compare October 10, 2023 21:41
@amysorto amysorto added target: major This PR is targeted for the next major release area: material/slider labels Oct 10, 2023
@amysorto amysorto marked this pull request as ready for review October 10, 2023 21:56
mmalerba
mmalerba approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amysorto amysorto added the action: merge The PR is ready for merge by the caretaker label Oct 11, 2023
@amysorto amysorto removed the request for review from devversion October 11, 2023 13:44
@amysorto amysorto merged commit 4787631 into angular:main Oct 11, 2023
27 of 29 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: material/slider target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amysorto @mmalerba