refactor(material/button): handle disabled states through tokens #28005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
commented
Oct 26, 2023
| @@ -89,15 +88,3 @@ | |||
| $query: mdc-helpers.$mdc-base-styles-query); | |||
| } | |||
| } | |||
|
|
|||
| // Changes a button token set to exclude the ripple styles. | |||
| @function mat-private-button-remove-ripple($tokens) { | |||
There was a problem hiding this comment.
Unrelated change, I just noticed that we weren't using this.
MDC applies disabled styles through the `:disabled` selector which forced us to work around it by using a selector like `.mat-mdc-button[disabled][disabled]` and setting both the disabled and enabled button tokens. This is problematic, because it increases the specificity too much and it introduces space for mistakes, because we have to duplicate the tokens values. These changes resolve the issue by re-applying the token slots to disabled buttons with the correct selector so that they can reuse the same tokens as the `button` nodes.
crisbeto
force-pushed
the
button-disabled-states
branch
from
0b14e66
to
78694f4
Compare
andrewseguin
approved these changes
Oct 26, 2023
|
Merging this manually through the UI. Will send a follow-up to cherry-pick into the RC branch. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MDC applies disabled styles through the
:disabledselector which forced us to work around it by using a selector like.mat-mdc-button[disabled][disabled]and setting both the disabled and enabled button tokens. This is problematic, because it increases the specificity too much and it introduces space for mistakes, because we have to duplicate the tokens values.These changes resolve the issue by re-applying the token slots to disabled buttons with the correct selector so that they can reuse the same tokens as the
buttonnodes.