refactor(cdk/a11y): factor out a typeahead class for key managers #28142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
reviewed
Nov 16, 2023
| } | ||
|
|
||
| // TODO: find a better name? | ||
| reset(): void { |
There was a problem hiding this comment.
I think reset is an appropriate name. What this does is allows the end user to restart typing by reseting the state of type letters to the initial state.
BobobUnicorn
force-pushed
the
cdk-tree-typeahead
branch
from
4aefcc8
to
abfa4a3
Compare
BobobUnicorn
requested review from
jelbourn,
devversion and
andrewseguin
as code owners
BobobUnicorn
force-pushed
the
cdk-tree-typeahead
branch
from
eb8d1eb
to
c32c07f
Compare
BobobUnicorn
force-pushed
the
cdk-tree-typeahead
branch
from
c32c07f
to
b702faf
Compare
zarend
approved these changes
Dec 6, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs cleanup