refactor(cdk/overlay): Reduce dependency on NgZone #28332
Conversation
atscott
force-pushed
the
afterNextRenderOverlayRef
branch
from
51b8b1b to
017331a
Compare
atscott
added
the
blocked
|
blocked by angular/angular#52455 |
|
eagerly awaiting this now that the blocker is resolved, will it also fix the tooltip positioning in zoneless? |
yes, this would fix the tooltip positioning in Zoneless. Note that the focus right now is finalizing the Zoneless implementation. There’s still plenty of work that needs to be done there before downstream fixes like this start to get more dedicated time and attention. |
atscott
force-pushed
the
afterNextRenderOverlayRef
branch
from
017331a to
36d9780
Compare
atscott
force-pushed
the
afterNextRenderOverlayRef
branch
from
36d9780 to
29652fa
Compare
mmalerba
removed
the
blocked
This updates the overlay implementation to use `afterNextRender` instead of `ngZone.onStable` which does not emit at all in zoneless applications. For zone-based applications, this means that the overlay will be positioned immediately after the next ApplicationRef tick. This is slightly different from `onStable`, which with ZoneJS can span multiple change detection rounds.
mmalerba
force-pushed
the
afterNextRenderOverlayRef
branch
from
4abdc4c to
8cda325
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
draft - Probably a breaking change and definitely not a good idea until
afterNextRenderruns only afterApplicationRef.tick. At the moment, this passes tests only because they're using fixtures and the fixtures are directly triggering change detection. However, in an application, the app component will refresh and triggerafterNextRenderbefore the overlay views are refreshed.