fix(material/badge): move structural styles out of theme #28452
Merged
+208
−178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
badge-structural-styles
branch
4 times, most recently
from
5a81b0c
to
f7ff9fd
Compare
crisbeto
commented
Jan 19, 2024
|
My understanding is that the base mixin is for tokens that can change based on the spec version. E.g. we emit the shape values there. |
|
SG - I'm not too opinionated about it |
andrewseguin
approved these changes
Jan 19, 2024
Totati
reviewed
Jan 19, 2024
crisbeto
force-pushed
the
badge-structural-styles
branch
from
f7ff9fd
to
feb3b04
Compare
Historically we've had the structural styles for the badge in the theme, because Angular doesn't support adding styles to a directive. This can lead to duplicate CSS and can be problematic for M3. These changes move the styles into a dummy component that is used to load the style only once per app.
crisbeto
force-pushed
the
badge-structural-styles
branch
from
feb3b04
to
d5e01ae
Compare
crisbeto
added a commit
that referenced
this pull request
Jan 19, 2024
Historically we've had the structural styles for the badge in the theme, because Angular doesn't support adding styles to a directive. This can lead to duplicate CSS and can be problematic for M3. These changes move the styles into a dummy component that is used to load the style only once per app. (cherry picked from commit 23e2f3e)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically we've had the structural styles for the badge in the theme, because Angular doesn't support adding styles to a directive. This can lead to duplicate CSS and can be problematic for M3.
These changes move the styles into a dummy component that is used to load the style only once per app.