Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/slider): error if slider is destroyed before first change detection #28494

Merged
merged 1 commit into from
Jan 29, 2024
Merged

fix(material/slider): error if slider is destroyed before first change detection #28494

merged 1 commit into from
Jan 29, 2024

Conversation

crisbeto
Copy link
Member

Fixes that the slider was throwing an error if it's destroyed before ngAfterViewInit has run.

Fixes #28475.

@crisbeto
fix(material/slider): error if slider is destroyed before first chang…
680c1f3 
…e detection

Fixes that the slider was throwing an error if it's destroyed before `ngAfterViewInit` has run.

Fixes angular#28475.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 29, 2024
wagnermaciel
wagnermaciel approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto self-assigned this Jan 29, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 29, 2024
@crisbeto crisbeto merged commit 4176633 into angular:main Jan 29, 2024
27 checks passed
crisbeto added a commit that referenced this pull request Jan 29, 2024
@crisbeto
fix(material/slider): error if slider is destroyed before first chang…
9e02a11 
…e detection (#28494)

Fixes that the slider was throwing an error if it's destroyed before `ngAfterViewInit` has run.

Fixes #28475.

(cherry picked from commit 4176633)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(MatSlider): MatSliderVisualThumb not properly destroyed
3 participants
@crisbeto @devversion @wagnermaciel