fix(material-experimental/theming): Make color API back-compat styles available #28526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
requested review from
crisbeto,
devversion,
andrewseguin and
jelbourn
as code owners
crisbeto
approved these changes
Feb 2, 2024
mmalerba
changed the title
mmalerba
force-pushed
the
m3-back-compat
branch
from
6615859
to
c2343a4
Compare
mmalerba
force-pushed
the
m3-back-compat
branch
from
c2343a4
to
9e79939
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes our back-compat styles to make chips and options with
.mat-primarysecondary colored rather than primary. This sounds odd, but the spec really treats "secondary" as an extended set of primary hues, and these components look much better when defaulted to secondary.A user who really does want the primary color can still get it by calling e.g.
@include mat.chips-theme($theme, $color-variant: primary), this only affects what our back-compat mixin outputs (@include matx.color-variants-back-compat($theme)).