Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/button-toggle): Add checkmark indicators with hideSingleSelectionIndicator and hideMultipleSelectionIndicator input and config options #28553

Merged
merged 2 commits into from Feb 27, 2024

Conversation

amysorto
Copy link
Contributor

@amysorto amysorto commented Feb 7, 2024

Needed as a part of the pre-work for M3, as well as a11y improvements.

@amysorto amysorto added Accessibility This issue is related to accessibility (a11y) area: material/button-toggle labels Feb 7, 2024
@zarend zarend added the dev-app preview When applied, previews of the dev-app are deployed to Firebase label Feb 7, 2024
Copy link
Contributor

@zarend zarend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API looks pretty conventional to me and matches the other components 👍 .

As far as I can tell, the only thing left in this PR is adding unit tests.

Copy link

github-actions bot commented Feb 7, 2024

Deployed dev-app for 89aaace to: https://ng-dev-previews-comp--pr-angular-components-28553-dev-p4ab7g6k.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@amysorto amysorto force-pushed the hide-multiple-selection-indicator branch 2 times, most recently from 02bea16 to 75a77e0 Compare February 7, 2024 22:44
@amysorto amysorto marked this pull request as ready for review February 7, 2024 22:46
@amysorto amysorto requested a review from zarend February 7, 2024 22:47
@amysorto amysorto force-pushed the hide-multiple-selection-indicator branch from 75a77e0 to 3c5c0f8 Compare February 7, 2024 22:49
@amysorto amysorto added the target: rc This PR is targeted for the next release-candidate label Feb 9, 2024
@amysorto amysorto force-pushed the hide-multiple-selection-indicator branch from 60ed027 to 89aaace Compare February 27, 2024 19:09
@amysorto amysorto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed target: rc This PR is targeted for the next release-candidate labels Feb 27, 2024
@amysorto amysorto merged commit 09111d0 into angular:main Feb 27, 2024
25 of 28 checks passed
@zarend
Copy link
Contributor

zarend commented Feb 27, 2024

🎉

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/button-toggle dev-app preview When applied, previews of the dev-app are deployed to Firebase target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants