fix(material/expansion): prevent focus from entering the panel while it's animating #28646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
27430/expansion-focus
branch
from
143aebb
to
bed6ece
Compare
…it's animating Currently the expansion panel prevents focus from entering it using `visibility: hidden`, but that only works when it's closed. This means that if the user tabs into it while it's animating, they may scroll the content make the component look broken. These changes resolve the issue by setting `inert` on the panel content while it's animating. Also cleans up an old workaround for IE. Fixes angular#27430. Fixes angular#28644.
crisbeto
force-pushed
the
27430/expansion-focus
branch
from
bed6ece
to
c631c97
Compare
amysorto
approved these changes
Feb 26, 2024
crisbeto
added a commit
that referenced
this pull request
Feb 26, 2024
…it's animating (#28646) Currently the expansion panel prevents focus from entering it using `visibility: hidden`, but that only works when it's closed. This means that if the user tabs into it while it's animating, they may scroll the content make the component look broken. These changes resolve the issue by setting `inert` on the panel content while it's animating. Also cleans up an old workaround for IE. Fixes #27430. Fixes #28644. (cherry picked from commit 24eaa2e)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the expansion panel prevents focus from entering it using
visibility: hidden, but that only works when it's closed. This means that if the user tabs into it while it's animating, they may scroll the content make the component look broken.These changes resolve the issue by setting
inerton the panel content while it's animating. Also cleans up an old workaround for IE.Fixes #27430.
Fixes #28644.