fix(multiple): derive all token values from theme #28664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
crisbeto
force-pushed
the
theming-fixes
branch
6 times, most recently
from
27bb88e
to
499289a
Compare
During the transition to tokens, we ended up with a bunch of places with hardcoded values in the form of `if($is-dark, #fff, #000)`. This is problematic for custom palettes, because the value is always hardcoded. These changes attempt to derive the same values from the palette directly. Fixes angular#26056.
crisbeto
force-pushed
the
theming-fixes
branch
from
499289a
to
8911168
Compare
crisbeto
requested review from
mmalerba,
andrewseguin and
jelbourn
as code owners
andrewseguin
approved these changes
Feb 29, 2024
crisbeto
added a commit
that referenced
this pull request
Feb 29, 2024
During the transition to tokens, we ended up with a bunch of places with hardcoded values in the form of `if($is-dark, #fff, #000)`. This is problematic for custom palettes, because the value is always hardcoded. These changes attempt to derive the same values from the palette directly. Fixes #26056. (cherry picked from commit cfdfa9a)
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 13, 2024
The changes from angular#28664 appear to have caused ripples to be solid in some setups. These changes add a fallback to the old behavior if that's the case. Fixes angular#28706.
crisbeto
added a commit
that referenced
this pull request
Mar 13, 2024
crisbeto
added a commit
that referenced
this pull request
Mar 13, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the transition to tokens, we ended up with a bunch of places with hardcoded values in the form of
if($is-dark, #fff, #000). This is problematic for custom palettes, because the value is always hardcoded.These changes attempt to derive the same values from the palette directly.
Fixes #26056.