M3 prebuilt themes #28779
Merged
M3 prebuilt themes #28779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from the backwards-compatibility styles Currently the color variant backwards-compatibility styles emit all tokens, even though they were likely emitted already by the theme. This ends up increasing the theme size by about 50kb. These changes add a `emit-overrides-only` parameter to the token utilities and use it to only emit the palette-specific styles from the backwards-compatibility mixin.
crisbeto
added
target: major
crisbeto
requested review from
mmalerba,
andrewseguin and
jelbourn
as code owners
Adds four new prebuilt themes that are using Material Design 3.
mmalerba
approved these changes
Mar 26, 2024
mmalerba
reviewed
Mar 26, 2024
There was a problem hiding this comment.
At some point I think we'll want to deprecate the color="..." API on the components, and at that point we might want to introduce a simpler class-based API to the predefined themes. I'm imagining something like:
<div class="mat-predefined-secondary">
All components in here are secondary color
<mat-checkbox />
<mat-radio />
</div>The mat-predefined-secondary would be a class you could add to any element to cause all child components to get secondary coloring. For now I think just including the back-compat styles is fine, but we'll want to revisit this later.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following changes:
fix(material-experimental/theming): avoid re-emitting the same tokens from the backwards-compatibility styles
Currently the color variant backwards-compatibility styles emit all tokens, even though they were likely emitted already by the theme. This ends up increasing the theme size by about 50kb.
These changes add a
emit-overrides-onlyparameter to the token utilities and use it to only emit the palette-specific styles from the backwards-compatibility mixin.feat(material/core): add prebuilt themes based on M3
Adds four new prebuilt themes that are using Material Design 3.