Use M3 in schematics and internal apps #28784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a guide that should've been deleted when we moved the MDC components to stable.
Updates the schematics to refer to the M3 prebuilt themes and to generate an M3 theme when the user selects `custom` in `ng add`.
crisbeto
added
target: major
angular-robot
bot
added
detected: feature
Switches unit tests, the e2e app and SSR app to use the M3 themes by default.
Updates the dev app to use the same default theme as the docs and `ng add` schematic.
crisbeto
requested review from
devversion,
josephperrott,
andrewseguin and
mmalerba
as code owners
wagnermaciel
approved these changes
Mar 27, 2024
crisbeto
removed request for
devversion,
josephperrott,
mmalerba and
andrewseguin
mmalerba
reviewed
Mar 27, 2024
| @@ -12,38 +12,38 @@ export function createCustomTheme(name: string = 'app') { | |||
| // Custom Theming for Angular Material | |||
| // For more information: https://material.angular.io/guide/theming | |||
| @use '@angular/material' as mat; | |||
| @use '@angular/material-experimental' as matx; | |||
There was a problem hiding this comment.
We probably don't want to include experimental stuff. Should we just wait on this until its moved out of experimental?
There was a problem hiding this comment.
I wanted to finish these instead of waiting for the code to be moved out of experimental. Once we do move them, it'll be quick to change the schematic.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits for more info, but the tl;dr is that these changes switch us to using M3 themes in all our tests and internal apps.