Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/sort): clear aria description on destroy #28801

Merged
merged 1 commit into from Apr 2, 2024

Conversation

crisbeto
Copy link
Member

Fixes that the sort header wasn't clearing its ARIA description when it gets destroyed, causing a memory leak.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 31, 2024
Fixes that the sort header wasn't clearing its ARIA description when it gets destroyed, causing a memory leak.
@crisbeto crisbeto added the G This is is related to a Google internal issue label Apr 1, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 2, 2024
@crisbeto crisbeto merged commit ced93a9 into angular:main Apr 2, 2024
26 of 28 checks passed
crisbeto added a commit that referenced this pull request Apr 2, 2024
Fixes that the sort header wasn't clearing its ARIA description when it gets destroyed, causing a memory leak.

(cherry picked from commit ced93a9)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants