Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/core): add migration for M2 theming APIs #28927

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

crisbeto
Copy link
Member

Adds a migration to account for the breaking changes in #28892. The migration changes all the places where functions and variables were renamed, as well as the usages of experimental APIs that were moved into stable.

Adds a migration to account for the breaking changes in angular#28892. The migration changes all the places where functions and variables were renamed, as well as the usages of experimental APIs that were moved into stable.
@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Apr 22, 2024
@crisbeto crisbeto marked this pull request as ready for review April 22, 2024 12:23
}
}

// If experimental is imported, but Material isn't, insert a new import at the top.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't the theming just not work in this case if people are doing this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some cases like with the color-back-compat mixin that could be used purely through experimental.

}

/** Renames all usages of a Sass function in a file. */
function migrateFunction(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lot of these helper functions might be useful to be in some shared place for any future ng-update schematics. Although I guess it's unlikely we would need these in another context soon.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I actually copied most of these from a migration that we deleted a few versions ago.

@crisbeto crisbeto self-assigned this Apr 23, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Apr 23, 2024
@crisbeto crisbeto merged commit 5501d9b into angular:main Apr 23, 2024
26 of 28 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants