Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(material/core): speed up M3 compilation #29009

Merged
merged 1 commit into from
May 7, 2024
Merged

perf(material/core): speed up M3 compilation #29009

merged 1 commit into from
May 7, 2024

Commits on May 7, 2024

  1. perf(material/core): speed up M3 compilation 

    Mitigates a compile time regression when generating M3 themes. These changes reduce the compilation time in half by caching the dummy theme instead of recreating it for each invocation. We can get away with this since the dummy theme is constant.

Although these changes are a significant improvement, there's more room for improvement. Timings for reference:

At head:
```
M2 benchmark - 35s
M3 benchmark - 90s
Theme from angular#28971 - 19s
```

After these changes changes:
```
M2 benchmark - 36s
M3 benchmark - 56s
Theme from angular#28971 - 10s
```

Relates to angular#28971.
    @crisbeto
    crisbeto committed May 7, 2024
    Configuration menu
    Copy the full SHA
    ae684b1 View commit details
    Browse the repository at this point in the history