refactor(multiple): Copy mdc-form-field tokens to individual components #29026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
changed the title
angular-robot
bot
added
the
area: build & ci
mmalerba
requested review from
devversion,
josephperrott,
andrewseguin and
crisbeto
as code owners
mmalerba
added
the
merge: preserve commits
crisbeto
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously several
--mdc-form-field-...tokens were shared between checkbox, radio, and slide-toggle. This introduced potential for accidentally changing styles on multiple components when trying to target just one. In order to resolve this, this PR gives each component its own uniquely named copy of the token:--mat-checkbox-...--mat-radio-...--mat-switch-...