Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/tree): aria-expanded attribute should not appear in the leaf node #29096

Merged
merged 2 commits into from
Jun 17, 2024
Merged

fix(material/tree): aria-expanded attribute should not appear in the leaf node #29096

merged 2 commits into from
Jun 17, 2024

Conversation

DBowen33
Copy link
Contributor

@DBowen33 DBowen33 commented May 22, 2024 •
edited
Loading

Fixed an issue to where leaf nodes were wrongly being assigned the aria-expanded attribute, which could confuse screen reader users.

https://screencast.googleplex.com/cast/NjMzNDkwNjM4MzcyODY0MHxkMTY5ZTdkNC05Mw

Fixes #21922
Fixes #21143

@DBowen33 DBowen33 marked this pull request as ready for review May 22, 2024 22:22
andrewseguin
andrewseguin reviewed Jun 7, 2024
View reviewed changes
src/cdk/tree/tree.ts Outdated Show resolved Hide resolved
@DBowen33 DBowen33 requested a review from a team as a code owner June 7, 2024 19:15
@DBowen33 DBowen33 requested review from wagnermaciel and removed request for a team June 7, 2024 19:15
@DBowen33 DBowen33 closed this Jun 7, 2024
@DBowen33 DBowen33 reopened this Jun 8, 2024
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 17, 2024
@andrewseguin andrewseguin merged commit 43b8dcb into angular:main Jun 17, 2024
23 of 26 checks passed
andrewseguin pushed a commit that referenced this pull request Jun 17, 2024
@DBowen33 @andrewseguin
fix(material/tree): aria-expanded attribute should not appear in the …
f834a11 
…leaf node (#29096)

* fix(material/tree): fixed unit tests

fixed unit tests

Fixes #21922

* fix(material/tree): updated public api file

updated public api file

Fixes #21922

(cherry picked from commit 43b8dcb)
andrewseguin added a commit to andrewseguin/components that referenced this pull request Jun 17, 2024
@andrewseguin
Revert "fix(material/tree): aria-expanded attribute should not appear…
cfe06bd 
… in the leaf node (angular#29096)"

This reverts commit 43b8dcb.
andrewseguin added a commit that referenced this pull request Jun 17, 2024
@andrewseguin
Revert "fix(material/tree): aria-expanded attribute should not appear…
004a943 
… in the leaf node (#29096)" (#29272)

This reverts commit 43b8dcb.
andrewseguin added a commit that referenced this pull request Jun 17, 2024
@andrewseguin
Revert "fix(material/tree): aria-expanded attribute should not appear…
90d1229 
… in the leaf node (#29096)" (#29272)

This reverts commit 43b8dcb.

(cherry picked from commit 004a943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
2 participants
@DBowen33 @andrewseguin