Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/slider): Tick marks changes position as the slider is changed (for a step that is decimal number) #29108

Merged
merged 1 commit into from
May 30, 2024
Merged

fix(material/slider): Tick marks changes position as the slider is changed (for a step that is decimal number) #29108

merged 1 commit into from
May 30, 2024

Commits on May 23, 2024

  1. fix(material/slider): Tick marks changes position as the slider is ch… 

    …anged (for a step that is decimal number)

Fixes the bug in the Angular Material 'slider' component.
Changed the function in the calculation from .floor to .round
Due to floating-point precision in JavaScript. (1 - 0.9) / 0.1 evaluates to 0.9999999999999999
Even though mathematically it should be 1
The calculation in the code resulted in slightly smaller value.
Math.floor(0.9999999999999999) evaluates to 0.
Math.round(0.9999999999999999) evaluates to 1.

Fixes angular#29084
    @lsamboretrorabbit
    lsamboretrorabbit committed May 23, 2024
    Configuration menu
    Copy the full SHA
    26cf9c0 View commit details
    Browse the repository at this point in the history