Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/datepicker): Move aria-live attribute so month can also … #29137

Merged
merged 1 commit into from
Jun 3, 2024
Merged

fix(material/datepicker): Move aria-live attribute so month can also … #29137

merged 1 commit into from
Jun 3, 2024

Conversation

amysorto
Copy link
Contributor

…be announced when using previous and next month buttons

@amysorto
fix(material/datepicker): Move aria-live attribute so month can also …
fcbef2d 
…be announced when using previous and next month buttons
@amysorto amysorto added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release area: material/datepicker action: global presubmit The PR is in need of a google3 global presubmit labels May 29, 2024
@amysorto
Copy link
Contributor Author

Note: This was originally fixed in #24398, but after adding a separate label element in #24958 the month wasn't announced anymore

@amysorto amysorto marked this pull request as ready for review May 30, 2024 15:27
@amysorto amysorto added action: merge The PR is ready for merge by the caretaker and removed action: global presubmit The PR is in need of a google3 global presubmit labels Jun 3, 2024
@amysorto amysorto merged commit b9fedfe into angular:main Jun 3, 2024
30 of 32 checks passed
amysorto added a commit that referenced this pull request Jun 3, 2024
@amysorto
fix(material/datepicker): Move aria-live attribute so month can also …
51488a2 
…be announced when using previous and next month buttons (#29137)

(cherry picked from commit b9fedfe)
@ambrose40 ambrose40 mentioned this pull request Jun 27, 2024
Open
@Addin Addin mentioned this pull request Jul 1, 2024
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/datepicker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amysorto @crisbeto