docs: provide example for global ErrorStateMatcher for standalone apps
#29219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-small
requested review from
amysorto and
wagnermaciel
and removed request for
a team
1) "remove empty code block" I added an extra `ts` code block example on accident in the previous PR 2) "rename comment": Change `Module` to `NgModule` for the existing example
mmalerba
reviewed
Jun 14, 2024
| @@ -65,11 +65,19 @@ applies to all inputs. For convenience, `ShowOnDirtyErrorStateMatcher` is availa | |||
| globally cause input errors to show when the input is dirty and invalid. | |||
|
|
|||
| ```ts | |||
| // NgModule applications | |||
There was a problem hiding this comment.
Can you split these into 2 separate code blocks? When its shown as one, I worry people might think they need to copy the entire snippet
There was a problem hiding this comment.
Good idea. Can it be two adjacent blocks like this
// NgModule applications
@NgModule({
providers: [
{provide: ErrorStateMatcher, useClass: ShowOnDirtyErrorStateMatcher}
]
})// Standalone applications
export const appConfig: ApplicationConfig = {
providers: [
{provide: ErrorStateMatcher, useClass: ShowOnDirtyErrorStateMatcher}
]
};or should the comments be pulled out into something like normal text above the blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant documentation page: https://material.angular.io/components/input/overview#changing-when-error-messages-are-shown
Edit: other page https://material.angular.io/components/select/overview#changing-when-error-messages-are-shown
ErrorStateMatcheris very useful, especially when added globally. This PR would add an example on how to use it globally in standalone applications.