fix(material/menu): animation issue when same menu is used for multiple nested triggers #29280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le nested triggers If the same menu is passed to different triggers and the user moves quickly between the menus (e.g. in a nested menu), an empty menu panel can show up while the closed menu is animating away. This is because the content needs to be moved over to the new menu. These changes hide the empty menu panel immediately using CSS to avoid the glichy behavior.
crisbeto
requested review from
amysorto and
mmalerba
and removed request for
a team
mmalerba
approved these changes
Jun 19, 2024
crisbeto
added a commit
that referenced
this pull request
Jun 19, 2024
…le nested triggers (#29280) If the same menu is passed to different triggers and the user moves quickly between the menus (e.g. in a nested menu), an empty menu panel can show up while the closed menu is animating away. This is because the content needs to be moved over to the new menu. These changes hide the empty menu panel immediately using CSS to avoid the glichy behavior. (cherry picked from commit 3550a87)
DBowen33
pushed a commit
to DBowen33/components
that referenced
this pull request
Jul 3, 2024
…le nested triggers (angular#29280) If the same menu is passed to different triggers and the user moves quickly between the menus (e.g. in a nested menu), an empty menu panel can show up while the closed menu is animating away. This is because the content needs to be moved over to the new menu. These changes hide the empty menu panel immediately using CSS to avoid the glichy behavior.
This was referenced Jul 12, 2024
This was referenced Jul 15, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the same menu is passed to different triggers and the user moves quickly between the menus (e.g. in a nested menu), an empty menu panel can show up while the closed menu is animating away. This is because the content needs to be moved over to the new menu.
These changes hide the empty menu panel immediately using CSS to avoid the glichy behavior.