feat(dialog): add result to MdDialogClose directive #4332

nallwhy · 2017-04-30T06:05:40Z

MdDialog has MdDialogClose to make it easier to structure a dialog.
But as MdDialogClose doesn't return any value, it's imposibble to use MdDialogClose if you want to get any return value when MdDialog is closed.
So @Input('md-dialog-close')result is added to MdDialogClose to solve it.

no breaking changes

jelbourn

Looks good, just needs a mention in the docs

jelbourn · 2017-05-01T21:15:48Z

src/lib/dialog/dialog-content-directives.ts

@@ -17,6 +17,9 @@ export class MdDialogClose {
  /** Screenreader label for the button. */
  @Input('aria-label') ariaLabel: string = 'Close dialog';

+  /** Result to return to the dialog opener. */
+  @Input('md-dialog-close') result: any;


Can you also update the overview in dialog.md to mention this feature?

@jelbourn I've done it! The tests below failed but the errors are not related to this commit.
What should I do?

This doesn't work in compatibility mode. We need something for mat-dialog-close too.

jelbourn

Just a couple comments on the docs

jelbourn · 2017-05-03T15:38:48Z

src/lib/dialog/dialog.md

+<md-dialog-actions>
+  <button md-button [md-dialog-close]="true">Yes</button>
+  <button md-button [md-dialog-close]="false">No</button>
+</md-dialog-actions>


One example should show the button without the value and one with, e.g.:

<h2 md-dialog-title>Delete all</h2> <md-dialog-content>Are you sure?</md-dialog-content> <md-dialog-actions> <button md-button md-dialog-close>Yes</button>  <button md-button [md-dialog-close]="false">No</button> </md-dialog-actions>

jelbourn · 2017-05-03T15:40:42Z

src/lib/dialog/dialog.md

+| `md-dialog-title`     | \[Attr] Dialog title, applied to a heading element (e.g., `<h1>`, `<h2>`)                            |
+| `<md-dialog-content>` | Primary scrollable content of the dialog                                                             |
+| `<md-dialog-actions>` | Container for action buttons at the bottom of the dialog                                             |
+| `md-dialog-close`     | \[Attr] Added to a `<button>`, makes the button close the dialog and return the binded value on click|


\[Attr] Added to a `<button>`, makes the button close the dialog with an optional result from the bound value.

jelbourn

LGTM

nallwhy · 2017-05-09T01:09:30Z

@devversion I've added mat-dialog-close.

devversion · 2017-05-09T16:02:02Z

src/lib/dialog/dialog-content-directives.ts

+  /** Result for compatibility mode */
+  @Input('mat-dialog-close')
+  get _matResult(): any { return this.result; }
+  set _matResult(r: any) { this.result = r; }


I think we can also have just the set here

/** Dialog close input for compatibility mode. */ @Input('mat-dialog-close') set _matDialogClose(value: any) { this.dialogResult = value; }

@devversion You are right. I've changed that.

MdDialog has MdDialogClose to make it easier to structure a dialog. But as MdDialogClose doesn't return any value, it's imposibble to use MdDialogClose if you want to get any return value when MdDialog is close. So `@Input('md-dialog-close')result` is added to MdDialogClose to solve it. no breaking changes

nallwhy · 2017-05-18T23:35:17Z

@devversion Any updates?

devversion · 2017-05-19T05:03:45Z

@nallwhy Sorry I forgot about it. It's now merge ready and should be merged soon! Thanks again

nallwhy · 2017-05-19T15:23:18Z

@devversion Thanks!

frederikaalund · 2017-06-22T13:03:09Z

Note that this changed the default value from undefined to the empty string. Example:

<button md-button md-dialog-close>No</button>

I ran into this issue when upgrading angular/material2. The fix was trivial:

<button md-button [md-dialog-close]="undefined">No</button>

Just leaving this here for others to see.

angular-automatic-lock-bot · 2019-09-06T14:02:08Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 30, 2017

nallwhy changed the title ~~feat(dialog): add result to MdDialogClose directive~~ feat(dialog): add result to MdDialogClose directive May 1, 2017

jelbourn reviewed May 1, 2017

View reviewed changes

nallwhy force-pushed the add_result_to_md-dialog-close branch 2 times, most recently from e56b469 to 66166c4 Compare May 3, 2017 12:38

jelbourn reviewed May 3, 2017

View reviewed changes

nallwhy force-pushed the add_result_to_md-dialog-close branch from 66166c4 to 0643a2e Compare May 3, 2017 17:23

jelbourn approved these changes May 3, 2017

View reviewed changes

jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 3, 2017

devversion removed the action: merge The PR is ready for merge by the caretaker label May 8, 2017

nallwhy force-pushed the add_result_to_md-dialog-close branch 2 times, most recently from 83d193f to b8365a8 Compare May 8, 2017 23:12

devversion reviewed May 9, 2017

View reviewed changes

nallwhy force-pushed the add_result_to_md-dialog-close branch 3 times, most recently from e1de055 to de86e14 Compare May 9, 2017 23:17

nallwhy force-pushed the add_result_to_md-dialog-close branch from de86e14 to b85fa23 Compare May 16, 2017 00:34

jelbourn added the action: merge The PR is ready for merge by the caretaker label May 19, 2017

tinayuangao merged commit c45dee2 into angular:master May 22, 2017

devversion mentioned this pull request Jul 17, 2017

Add value to md-dialog-close attribute #4421

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dialog): add result to MdDialogClose directive #4332

feat(dialog): add result to MdDialogClose directive #4332

nallwhy commented Apr 30, 2017 •

edited

jelbourn left a comment

jelbourn May 1, 2017

nallwhy May 3, 2017

devversion May 8, 2017

jelbourn left a comment

jelbourn May 3, 2017

nallwhy May 3, 2017

jelbourn May 3, 2017

jelbourn left a comment

nallwhy commented May 9, 2017

devversion May 9, 2017 •

edited

nallwhy May 9, 2017

nallwhy commented May 18, 2017

devversion commented May 19, 2017

nallwhy commented May 19, 2017

frederikaalund commented Jun 22, 2017

angular-automatic-lock-bot bot commented Sep 6, 2019

feat(dialog): add result to MdDialogClose directive #4332

feat(dialog): add result to MdDialogClose directive #4332

Conversation

nallwhy commented Apr 30, 2017 • edited

jelbourn left a comment

Choose a reason for hiding this comment

jelbourn May 1, 2017

Choose a reason for hiding this comment

nallwhy May 3, 2017

Choose a reason for hiding this comment

devversion May 8, 2017

Choose a reason for hiding this comment

jelbourn left a comment

Choose a reason for hiding this comment

jelbourn May 3, 2017

Choose a reason for hiding this comment

nallwhy May 3, 2017

Choose a reason for hiding this comment

jelbourn May 3, 2017

Choose a reason for hiding this comment

jelbourn left a comment

Choose a reason for hiding this comment

nallwhy commented May 9, 2017

devversion May 9, 2017 • edited

Choose a reason for hiding this comment

nallwhy May 9, 2017

Choose a reason for hiding this comment

nallwhy commented May 18, 2017

devversion commented May 19, 2017

nallwhy commented May 19, 2017

frederikaalund commented Jun 22, 2017

angular-automatic-lock-bot bot commented Sep 6, 2019

nallwhy commented Apr 30, 2017 •

edited

devversion May 9, 2017 •

edited