Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox, radio): Fix checkbox label not read in JAWS #4610

Merged
merged 2 commits into from
May 25, 2017

Conversation

tinayuangao
Copy link
Contributor

@tinayuangao tinayuangao commented May 16, 2017

Fixes #3584 #3586

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 16, 2017
@tinayuangao tinayuangao changed the title fix(checkbox): Fix checkbox label not read in JAWS fix(checkbox, a11y): Fix checkbox label not read in JAWS May 16, 2017
@tinayuangao tinayuangao force-pushed the checkbox-access branch 2 times, most recently from e93576b to 23b9054 Compare May 17, 2017 00:08
@tinayuangao tinayuangao added in progress This issue is currently in progress and removed pr: needs review labels May 17, 2017
@jelbourn
Copy link
Member

Can you describe the problem this is fixing? According to the HTML spec, adding for should be equivalent to the form control being inside of the <label>

@tinayuangao tinayuangao force-pushed the checkbox-access branch 2 times, most recently from 7b16d07 to 13b28f8 Compare May 18, 2017 21:41
@tinayuangao tinayuangao changed the title fix(checkbox, a11y): Fix checkbox label not read in JAWS fix(checkbox, radio): Fix checkbox label not read in JAWS May 18, 2017
@tinayuangao
Copy link
Contributor Author

The problem is JAWS doesn't read the label for radio button or checkbox. Moving input element out of label solves this problem. But according to spec, we could use label in both ways.

@jelbourn
Copy link
Member

Can you reproduce the behavior on a simple html page with

<label>
  Active
  <input type="checkbox">
</label>

Or does it only happen w/ the material components?

@tinayuangao
Copy link
Contributor Author

It only happen w/ the material components.

<md-checkbox>Active</md-checkbox> doesn't work while
<md-checkbox>Active<span>more info</span></md-checkbox> works.

@tinayuangao tinayuangao added pr: needs review and removed in progress This issue is currently in progress labels May 19, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added Accessibility This issue is related to accessibility (a11y) pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 23, 2017
@tinayuangao tinayuangao merged commit 5c48949 into angular:master May 25, 2017
crisbeto added a commit to crisbeto/material2 that referenced this pull request Nov 27, 2018
Along the same lines as angular#4610. Adds an extra element to allow for JAWS to pick up the label.
jelbourn pushed a commit that referenced this pull request Nov 28, 2018
Along the same lines as #4610. Adds an extra element to allow for JAWS to pick up the label.
jelbourn pushed a commit that referenced this pull request Nov 28, 2018
Along the same lines as #4610. Adds an extra element to allow for JAWS to pick up the label.
jelbourn pushed a commit that referenced this pull request Dec 3, 2018
Along the same lines as #4610. Adds an extra element to allow for JAWS to pick up the label.
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
Along the same lines as angular#4610. Adds an extra element to allow for JAWS to pick up the label.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A11y keyboard focus control in Checkbox Component
4 participants