Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make mixin base classes docs private #5301

Merged
merged 1 commit into from
Jun 23, 2017
Merged

refactor: make mixin base classes docs private #5301

merged 1 commit into from
Jun 23, 2017

Conversation

devversion
Copy link
Member

  • The base classes that are used to apply mixins should not be show up in the generated docs

@devversion
refactor: make mixin base classes docs private
97794da 
* The base classes that are used to apply mixins should not be show up in the generated docs
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 22, 2017
willshowell added a commit to willshowell/material2 that referenced this pull request Jun 22, 2017
@willshowell
make mixin base classes docs private (angular#5301)
63247e6
jelbourn
jelbourn approved these changes Jun 23, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 23, 2017
@jelbourn jelbourn merged commit d84998b into angular:master Jun 23, 2017
@devversion devversion deleted the refactor/docs-mixins-private branch June 23, 2017 16:05
willshowell added a commit to willshowell/material2 that referenced this pull request Jul 10, 2017
@willshowell
make mixin base classes docs private (angular#5301)
c887c49
willshowell added a commit to willshowell/material2 that referenced this pull request Jul 14, 2017
@willshowell
make mixin base classes docs private (angular#5301)
a15effc
kara pushed a commit that referenced this pull request Jul 20, 2017
@willshowell @kara
make mixin base classes docs private (#5301)
d638888
willshowell added a commit to willshowell/material2 that referenced this pull request Jul 20, 2017
@willshowell
feat(tabs): add theming and ability to set background color
1efac4b 
- Rework sass for smaller output

- make mixin base classes docs private (angular#5301)

- Use each directive for less repetition

- Rename background to backgroundColor
willshowell added a commit to willshowell/material2 that referenced this pull request Jul 21, 2017
@willshowell
feat(tabs): add theming and ability to set background color
2729c43 
- Rework sass for smaller output

- make mixin base classes docs private (angular#5301)

- Use each directive for less repetition

- Rename background to backgroundColor
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devversion @jelbourn @googlebot