-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(menu): wrong animation in Angular 4.2+ #5836
Conversation
src/lib/menu/menu-animations.ts
Outdated
@@ -34,11 +35,11 @@ import{ | |||
export const transformMenu: AnimationTriggerMetadata = trigger('transformMenu', [ | |||
state('void', style({ | |||
opacity: 0, | |||
transform: 'scale(0, 0)' | |||
transform: 'scale(0.01, 0.01)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment for this workaround?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Fixes the new menu animation glitching out against Angular 4.2. It seems like transitioning from `scale(0, 0)` to `scale(1, 0.5)` works correctly at the moment. This is a workaround that will transition it from `scale(0.01, 0.01)` instead.
6d73e88
to
e923544
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note: Screenshot tests need to be fixed |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes the new menu animation glitching out against Angular 4.2. It seems like transitioning from
scale(0, 0)
toscale(1, 0.5)
doesn't work correctly at the moment. This is a workaround that will transition it fromscale(0.01, 0.01)
instead.For reference:
![zp7kn12](https://user-images.githubusercontent.com/4450522/28308994-9dcf7464-6bb0-11e7-9c4c-8c75d72c3121.gif)