Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(table): simplify first basic example #6177

Merged
merged 4 commits into from
Aug 2, 2017
Merged

docs(table): simplify first basic example #6177

merged 4 commits into from
Aug 2, 2017

Conversation

andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Jul 31, 2017 •
edited
Loading

Fixes #6036

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 31, 2017
@andrewseguin
Copy link
Contributor Author

Sorry, first PR was accidently done off my master, duh

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 31, 2017
willshowell
willshowell reviewed Jul 31, 2017
View reviewed changes
src/material-examples/table-basic/table-basic-example.ts Outdated
@@ -79,13 +51,9 @@ export class ExampleDatabase {
* should be rendered.
*/
export class ExampleDataSource extends DataSource<any> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should be updated to not reference ExampleDatabase

@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Jul 31, 2017
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Aug 1, 2017
@tinayuangao
Copy link
Contributor

@ andrewseguin Could you please check the travis test failures?

@andrewseguin
Copy link
Contributor Author

Tests now pass, thanks

@tinayuangao
Copy link
Contributor

@andrewseguin could you please rebase? Thanks

@tinayuangao tinayuangao merged commit a043bec into angular:master Aug 2, 2017
@andrewseguin andrewseguin deleted the table-simple-basic-example branch April 17, 2018 17:23
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@willshowell willshowell willshowell left review comments

@mmalerba mmalerba mmalerba approved these changes

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

@amcdnl amcdnl Awaiting requested review from amcdnl

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Table] simpler example without example database
5 participants
@andrewseguin @tinayuangao @willshowell @mmalerba @googlebot