Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocomplete,datepicker,menu): closing parent dialog by pressing escape #6226

Merged
merged 1 commit into from
Aug 2, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 2, 2017

Prevents the autocomplete, datepicker and menu components from closing their parent dialog when the user presses escape.

Fixes #6223.

…escape

Prevents the autocomplete, datepicker and menu components from closing their parent dialog when the user presses escape.

Fixes angular#6223.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 2, 2017
@crisbeto
Copy link
Member Author

crisbeto commented Aug 2, 2017

@jelbourn some food for thought: considering that interactions should be scoped to a particular overlay, perhaps we should stopPropagation on keyboard and mouse events for all overlays by default?

Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 2, 2017
@jelbourn
Copy link
Member

jelbourn commented Aug 2, 2017

@crisbeto my instinct is that always doing stopPropagation is overly broad, but don't have any concrete reasons why right now

@tinayuangao tinayuangao merged commit 916d1f3 into angular:master Aug 2, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escaping out of menu/autocomplete within a dialog causes the dialog to close
5 participants