Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(slide-toggle): remove side-margin if slide-toggle label is empty #6881

Merged
merged 1 commit into from Sep 12, 2017
Merged

fix(slide-toggle): remove side-margin if slide-toggle label is empty #6881

merged 1 commit into from Sep 12, 2017

Conversation

devversion
Copy link
Member

Fixes #6868

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 6, 2017
jelbourn
jelbourn approved these changes Sep 6, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

jelbourn commented Sep 6, 2017

@devversion actually this is failing on the prerender task

@devversion
Copy link
Member Author

@jelbourn Ahh I see. Fixed it.

@jelbourn
Copy link
Member

jelbourn commented Sep 7, 2017 

 Property 'checkboxLabel' does not exist on type 'MdSlideToggle'.

@devversion devversion force-pushed the fix/slide-toggle-empty-label-margin branch from f494bae to a9acfe1 Compare September 7, 2017 20:56
@devversion
fix(slide-toggle): remove side-margin if slide-toggle label is empty
c476c0a 
* Removes the side-margin of the actual indicator of the slide-toggle if the user label is empty (similar as in angular#4730)

Fixes angular#6868
@devversion devversion force-pushed the fix/slide-toggle-empty-label-margin branch from a9acfe1 to c476c0a Compare September 7, 2017 21:05
@devversion
Copy link
Member Author

@jelbourn Updated again

jelbourn
jelbourn approved these changes Sep 8, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 8, 2017
@mmalerba mmalerba merged commit a1ec81a into angular:master Sep 12, 2017
josephperrott pushed a commit to josephperrott/components that referenced this pull request Sep 15, 2017
@devversion @josephperrott
fix(slide-toggle): remove side-margin if slide-toggle label is empty (a…
bf91a89 
…ngular#6881)

* Removes the side-margin of the actual indicator of the slide-toggle if the user label is empty (similar as in angular#4730)

Fixes angular#6868
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slide toggle not centered when no text/label
5 participants
@devversion @jelbourn @googlebot @mmalerba @tinayuangao