Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu): wrong offset for nested menu in a fallback position #7562

Merged
merged 1 commit into from Oct 12, 2017
Merged

fix(menu): wrong offset for nested menu in a fallback position #7562

merged 1 commit into from Oct 12, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 5, 2017

  • Adds the ability to set offsets on connected position fallbacks.
  • Fixes wrong positioning of nested menu if they're in a fallback position.

Fixes #7549.

@crisbeto
fix(menu): wrong offset for nested menu in a fallback position
aebbe66 
* Adds the ability to set offsets on connected position fallbacks.
* Fixes wrong positioning of nested menu if they're in a fallback position.

Fixes angular#7549.
@crisbeto crisbeto requested a review from kara as a code owner October 5, 2017 19:54
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 5, 2017
jelbourn
jelbourn approved these changes Oct 6, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 6, 2017
@kara kara added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Oct 6, 2017
@andrewseguin andrewseguin merged commit 074f6ce into angular:master Oct 12, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@kara kara Awaiting requested review from kara

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested menu is not aligned upwards(?)
5 participants
@crisbeto @jelbourn @kara @googlebot @andrewseguin