-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No files are written: mkdir@1.0.0 broke mkdir-promise as such writeFile processor broke #287
Comments
Thoughts...just thoughs...
|
How about we just update dgeni-packages to using |
Sounds good to me! |
I just got hit by this when updating AIO 🙀 |
The `mkdirp-promise` dependency had its own dependency of `"mkdirp": "*"`. But recently `mkdirp` did a new breaking change release that is no longer compatible with `mkdirp-promise`. This was causing the `writeFile()` service never to resolve its own promise, which resulted in files not getting written to the disk. This commit removes the dependency on `mkdirp-promise` since `mkdirp` now supports returning a promise directly. Fixes #287
The `mkdirp-promise` dependency had its own dependency of `"mkdirp": "*"`. But recently `mkdirp` did a new breaking change release that is no longer compatible with `mkdirp-promise`. This was causing the `writeFile()` service never to resolve its own promise, which resulted in files not getting written to the disk. This commit removes the dependency on `mkdirp-promise` since `mkdirp` now supports returning a promise directly. Fixes #287
Thanks for raising this @dherges - it must have been quite a pain to debug what was going on! |
you're welcome! I had this thought to modify the dgeni code to work with different versions of the dependencies, and that would have required several "if/else" checks... Just updating the dependencies ( |
- pin `dgeni-packages` to `0.27.5` as `0.28.0` includes a breaking change - https://github.com/angular/dgeni-packages/blob/master/CHANGELOG.md#0280-12-july-2019 - pin `mkdirp` to `0.5.1` to be compatible with `dgeni-packages@0.27.x` - angular/dgeni-packages#287
- pin `dgeni-packages` to `0.27.5` as `0.28.0` includes a breaking change - https://github.com/angular/dgeni-packages/blob/master/CHANGELOG.md#0280-12-july-2019 - pin `mkdirp` to `0.5.1` to be compatible with `dgeni-packages@0.27.x` - angular/dgeni-packages#287
- pin `dgeni-packages` to `0.27.5` as `0.28.0` includes a breaking change - https://github.com/angular/dgeni-packages/blob/master/CHANGELOG.md#0280-12-july-2019 - pin `mkdirp` to `0.5.1` to be compatible with `dgeni-packages@0.27.x` - angular/dgeni-packages#287
mkdirp@1.0.0 changed implementation from callback to promisified api
mkdir-promise has
"mkdirp": "*"
dependency: https://github.com/ahmadnassri/mkdirp-promise/blob/master/package.json#L37As such, the writeFile stopped working because the Promise never resolves.
https://github.com/angular/dgeni-packages/blob/master/base/services/writeFile.js#L1
I fixed it locally in a project workspace by overriding the factory with a custom implementation:
The text was updated successfully, but these errors were encountered: