perf(injector): skip _checkKeyConditions in dart2js

dart-archive · Apr 14, 2014 · 6763552 · 6763552
1 parent 347a6fb
commit 6763552
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/injector.dart b/lib/injector.dart
@@ -90,7 +90,7 @@ class Injector {
   }
 
   dynamic _getInstanceByKey(Key key, Injector requester) {
-    _checkKeyConditions(key);
+    assert(_checkKeyConditions(key));
 
     if (resolving.contains(key)) {
       throw new CircularDependencyError(
@@ -154,11 +154,12 @@ class Injector {
     throw new NoProviderError(_error('No provider found for ${key}!', key));
   }
 
-  void _checkKeyConditions(Key key) {
+  bool _checkKeyConditions(Key key) {
     if (_PRIMITIVE_TYPES.contains(key)) {
       throw new NoProviderError(_error('Cannot inject a primitive type '
           'of ${key.type}!', key));
     }
+    return true;
   }