fix: querySelector returns null when nothing is found.
#16
Conversation
test/web-platform-tests.js
Outdated
| @@ -81,271 +81,271 @@ function read(file) { | |||
| return fs.readFileSync(Path.resolve(__dirname, '..', file), 'utf8'); | |||
| } | |||
|
|
|||
| var testharness = require(__dirname + '/web-platform-tests/resources/testharness.js'); | |||
| // var testharness = require(__dirname + '/web-platform-tests/resources/testharness.js'); | |||
There was a problem hiding this comment.
Please uncomment this file. While all the tests don't pass, we do have some that we need and rely on.
There was a problem hiding this comment.
I'm probably missing some insights here. I was getting an error because that particular file doesn't exisit on the repo. Hense all the commented code.
Also to me that variable wasn't even used, the tests using the harness function were comment at the end of the file !
|
FYI, this would be a breaking change, we should make sure we merge it once the main branch is available for v17 changes. |
|
@AndrewKushnir While I get that it feels like a breaking change, I thought It would be more of a fix since we have a different behavior between Browser and SSR. |
@JeanMeche agreed, this is a legit fix, but it'd still be breaking for cases where there is a strict comparison like |
|
Hi Angular team, do you have an update on when you think this issue will be resolved? |
Also: commenting unused tests code that prevented running the unit tests. Fixes angular/angular#51068
JeanMeche
force-pushed
the
fix/querySelector
branch
from
05028b1
to
e2a1969
Compare
Also: commenting unused test code that prevented from running the unit tests.
Fixes angular/angular#51068