-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fxLayoutGap): consider fxLayoutWrap to apply gap logic #148
Conversation
@here - merge after PR 145. |
@d3viant0ne - please review. |
@ThomasBurleson I tried your PR on my demo and it's great 😄 One thing tho, when elements are going to the next line (fxLayoutWrap), they don't have a margin-top. I think it would be a good idea to apply the gap not only horizontally between elements but also vertically, don't you think ? |
@maxime1992 - the gap will only be applied along the main-axis.
|
Ok I skipped that part, my bad. If there's no On the contrary, when the |
f8b84d1
to
54efdfe
Compare
54efdfe
to
145d658
Compare
dad69fe
to
aaeb525
Compare
* `margin-right` be used with `fxLayout="row" fxLayoutWrap fxLayoutGap` combinations * `margin-bottom` be used with `fxLayout="column" fxLayoutWrap fxLayoutGap` combinations fixes #108.
145d658
to
8ac81bf
Compare
…ons (angular#148) * `margin-right` be used with `fxLayout="row" fxLayoutWrap fxLayoutGap` combinations * `margin-bottom` be used with `fxLayout="column" fxLayoutWrap fxLayoutGap` combinations fixes angular#108.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
margin-right
be used withfxLayout="row" fxLayoutWrap fxLayoutGap
combinationsmargin-bottom
be used withfxLayout="column" fxLayoutWrap fxLayoutGap
combinationsfixes #108