Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange bug: when using fxLayoutGap on container and *ngFor on child #329

Closed
sasensi opened this issue Jun 25, 2017 · 4 comments · Fixed by #370
Closed

Strange bug: when using fxLayoutGap on container and *ngFor on child #329

sasensi opened this issue Jun 25, 2017 · 4 comments · Fixed by #370
Assignees
@ThomasBurleson
Labels
has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease
Milestone
v2.0.0-beta.9

Comments

@sasensi
Copy link

sasensi commented Jun 25, 2017

Hi,

I found a strange bug which, I presume, has something to do with fxLayoutGap directive.

My use case was to use a component method to provide items for a *ngFor loop.
I noticed that if the parent of the loop has the directive fxLayoutGap, browser just crash (tested on Chrome and Firefox).
Demo here: https://plnkr.co/edit/paJ7Sb

Hoping you can help me on this.

Thanks in advance.
@ThomasBurleson
Copy link
Contributor

@sasensi - that is a great, nasty bug discovery. We will investigate.

@ThomasBurleson ThomasBurleson added this to the v2.0.0-beta.9 milestone Jun 25, 2017
@ThomasBurleson ThomasBurleson added the P1 Urgent issue that should be resolved before the next re-lease label Jun 25, 2017
@ThomasBurleson ThomasBurleson self-assigned this Jun 25, 2017
@lordjesus
Copy link

Any news on this? I am facing the exact same issue.

ThomasBurleson added a commit that referenced this issue Aug 8, 2017
@ThomasBurleson
fix(fxLayoutGap): mutation observer should run outside the ngZone
fe9d020 
Inside the ngZone, the mutation observer and _updateWithValue() style changes causes an infinite recursion. MutationObserver handlers should be executed outside the ngZone.

Fixes #329.
@ThomasBurleson ThomasBurleson mentioned this issue Aug 8, 2017
Merged
@ThomasBurleson
Copy link
Contributor

@lordjesus - see PR #370.

@ThomasBurleson ThomasBurleson added has pr A PR has been created to address this issue and removed in-progress labels Aug 8, 2017
ThomasBurleson added a commit that referenced this issue Aug 8, 2017
@ThomasBurleson
fix(fxLayoutGap): mutation observer should run outside the ngZone
23f4f1d 
Inside the ngZone, the mutation observer and _updateWithValue() style changes causes an infinite recursion. MutationObserver handlers should be executed outside the ngZone.

Fixes #329.
mmalerba pushed a commit that referenced this issue Aug 9, 2017
@ThomasBurleson @mmalerba
fix(fxLayoutGap): mutation observer should run outside the ngZone (#370)
9fb0877 
Inside the ngZone, the mutation observer and _updateWithValue() style changes causes an infinite recursion. MutationObserver handlers should be executed outside the ngZone.

Fixes #329.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ThomasBurleson ThomasBurleson

Labels
has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease
Projects
None yet
Milestone
v2.0.0-beta.9
Development

Successfully merging a pull request may close this issue.

fix(fxLayoutGap): mutation observer should run outside the ngZone angular/flex-layout
3 participants
@ThomasBurleson @lordjesus @sasensi