Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): add browser check for MatchMedia #624

Closed
wants to merge 1 commit into from
Closed

Conversation

CaerusKaru
Copy link
Member

  • Add back the browser check in MatchMedia so that when the
    server module isn't loaded, there are no lingering window
    errors

@CaerusKaru CaerusKaru added this to the v5.0.0-beta.13 milestone Feb 18, 2018
@CaerusKaru CaerusKaru force-pushed the adam/fix-ssr branch 3 times, most recently from 0978668 to 1d58a7e Compare February 18, 2018 13:11
@CaerusKaru CaerusKaru added the P0 Critical issue that needs to be resolved immediately label Feb 18, 2018
* Add back the browser check in MatchMedia so that when the
  server module isn't loaded, there are no lingering window
  errors
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes P0 Critical issue that needs to be resolved immediately pr: needs review ssr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants